-
Notifications
You must be signed in to change notification settings - Fork 160
fix: bump all-contributors-cli to ^6.26.1 #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: bump all-contributors-cli to ^6.26.1 #508
Conversation
|
@JoshuaKGoldberg is attempting to deploy a commit to the All Contributors Team on Vercel. A member of the Team first needs to authorize it. |
|
@JoshuaKGoldberg so are you able to help us get this deployment working again (and help me understand how it works)? It seems like CI / deployment is not working. Many thanks!! |
|
@all-contributors please add @JoshuaKGoldberg for code |
|
I've put up a pull request to add @JoshuaKGoldberg! 🎉 |
Adds @JoshuaKGoldberg as a contributor for code. This was requested by lwasser [in this comment](#508 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
Oh this is running on node 16... we need to bump to 22. |
|
Yeah for sure! I don't deeply know the specifics of all-contributors but I'm quite familiar with the general systems in play. I haven't been keeping too close of an eye on your efforts - where would you like me to help? For the Vercel build, I don't have access to debug. Could you invite I also emailed a link to my calendar link if you prefer real-time meetings. Either way works for me. Edit: and, I sent #528 to get CI running. That should be most of the issues within the app code, I think. |
|
Wonderful @JoshuaKGoldberg, I'm getting to know the infra here too, but it sounds like you have some much needed expertise with both Vercel and JS, and I will be learning both as will @JimMadge ! I did respond to your email :) I've been extremely busy this past week, so I apologize. I read your email and added you as a maintainer, but I also forgot to respond to your email. That was a communication mistake on my part. Let's develop a plan to update the app, and then it seems we may want to clean up / refactor the code to create a CLI package that can be used both here and by CLI users. There is an open issue about this. But for now, I'm unsure how to test your PR here to ensure it won't break the bot. As we figure things out, I want to ensure that we update documentation as well so new contribs don't have to figure this all out too ✨ |
|
@JoshuaKGoldberg i'm going to update this branch from main. I added the update branch button to pr's in the settings. |
What: Fixes #507
Why: Aligns the app to the latest version of the CLI.
How: Updating the dependency entry in
package.jsonand then runningnpm iChecklist:
[ ] Documentationn/aBot Usage